Always set index #828

newzealandpaul · 2024-10-03T02:26:48Z

The index should always be set, because it will be accessed later in the script and generate a runtime error

What does this PR do?

Sets the index variable to the config's id_start_number, even if id_field was already in the header

Why is this desirable ?

When each row is iterated later on in the script, index will be accessed. If it is not set, a runtime error occurs.

        if config["id_field"] in headers:
            row[config["id_field"]] = index + reader.line_num - 2

The index should always be set, because it will be accessed later in the script and generate a runtime error

mjordan · 2024-10-03T04:43:56Z

Thanks @newzealandpaul . How would I test this change?

newzealandpaul · 2024-10-03T05:55:12Z

@mjordan thanks for taking a look. Next week when I am on campus I will try figure out why my use case specifically requires it (when it must be initialised for others). Looking at the code, is there any situation or code path where you wouldn’t want to initialise index? If index isn’t initialised then it should always cause a runtime error. Or am I missing something?

…

On Thu, 3 Oct 2024 at 5:44 PM, Mark Jordan ***@***.***> wrote: Thanks @newzealandpaul <https://github.com/newzealandpaul> . How would I test this change? — Reply to this email directly, view it on GitHub <#828 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAACLSGTOTSLTDDYSOXPCNDZZTDSFAVCNFSM6AAAAABPI3DED2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJQGUYDMOJTGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

newzealandpaul · 2024-10-15T22:58:50Z

If index is not set this error occurs, which makes sense:

Traceback (most recent call last):
 File "islandora_workbench/i7Import/get_islandora_7_content.py", line 118, in <module>
   row[config["id_field"]] = index + reader.line_num - 2
                             ^^^^^
NameError: name 'index' is not defined

My condig looks like this:

solr_base_url: 'http://X/solr/collection'
islandora_base_url: 'http://X/'
csv_output_path: 'islandora7_metadata.csv'
obj_directory: '/tmp/objs'
log_file_path: 'islandora_content.log'
id_field: 'PID'
rows: 100
id_start_number: 1
pids_to_skip: []
collection: islandora:root
debug: true
deep_debug: true

I think this is a valid config, with my install the pull request proposed here is required. I think this would effect other users too . There can't be any downside to setting the index.

mjordan · 2024-10-15T23:04:19Z

OK, thank you, merged.

Always set index

985a594

The index should always be set, because it will be accessed later in the script and generate a runtime error

mjordan merged commit 44a873d into mjordan:main Oct 15, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Always set index #828

Always set index #828

newzealandpaul commented Oct 3, 2024

mjordan commented Oct 3, 2024

newzealandpaul commented Oct 3, 2024 via email •

edited

Loading

newzealandpaul commented Oct 15, 2024

mjordan commented Oct 15, 2024

Always set index #828

Always set index #828

Conversation

newzealandpaul commented Oct 3, 2024

What does this PR do?

Why is this desirable ?

mjordan commented Oct 3, 2024

newzealandpaul commented Oct 3, 2024 via email • edited Loading

newzealandpaul commented Oct 15, 2024

mjordan commented Oct 15, 2024

newzealandpaul commented Oct 3, 2024 via email •

edited

Loading